]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mqueue: fix a use-after-free in sys_mq_notify()
authorCong Wang <xiyou.wangcong@gmail.com>
Sun, 9 Jul 2017 20:19:55 +0000 (13:19 -0700)
committerTim Tianyang Chen <tianyang.chen@oracle.com>
Thu, 24 Aug 2017 17:25:32 +0000 (10:25 -0700)
commitd6cb3b8de682564c86b09c56e43162e873769d0e
tree338a85f965d2a4c1c0ee52e3ed64487a3ee66aea
parenta02187d44cde5207fdd22b4b80f63e1618e6aa40
mqueue: fix a use-after-free in sys_mq_notify()

The retry logic for netlink_attachskb() inside sys_mq_notify()
is nasty and vulnerable:

1) The sock refcnt is already released when retry is needed
2) The fd is controllable by user-space because we already
   release the file refcnt

so we when retry but the fd has been just closed by user-space
during this small window, we end up calling netlink_detachskb()
on the error path which releases the sock again, later when
the user-space closes this socket a use-after-free could be
triggered.

Setting 'sock' to NULL here should be sufficient to fix it.

Reported-by: GeneBlue <geneblue.mail@gmail.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Manfred Spraul <manfred@colorfullife.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
(cherry picked from commit f991af3daabaecff34684fd51fac80319d1baad1)

Orabug: 26584960
CVE: CVE-2017-11176

Signed-off-by: Tim Tianyang Chen <tianyang.chen@oracle.com>
Reviewed-by: Jack Vogel <jack.vogel@oracle.com>
ipc/mqueue.c