]> www.infradead.org Git - users/hch/misc.git/commit
NFSD: Implement FATTR4_CLONE_BLKSIZE attribute
authorChuck Lever <chuck.lever@oracle.com>
Wed, 7 May 2025 14:45:15 +0000 (10:45 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Sun, 11 May 2025 23:48:29 +0000 (19:48 -0400)
commitd6ca7d2643eebe09cf46840bdc7d68b6e07aba77
tree6911a9c83ca55b21c036605df0d4062fd6e5df0c
parentc2c90a8b2620626cdb3eb315c2fafcc19fe24ee6
NFSD: Implement FATTR4_CLONE_BLKSIZE attribute

RFC 7862 states that if an NFS server implements a CLONE operation,
it MUST also implement FATTR4_CLONE_BLKSIZE. NFSD implements CLONE,
but does not implement FATTR4_CLONE_BLKSIZE.

Note that in Section 12.2, RFC 7862 claims that
FATTR4_CLONE_BLKSIZE is RECOMMENDED, not REQUIRED. Likely this is
because a minor version is not permitted to add a REQUIRED
attribute. Confusing.

We assume this attribute reports a block size as a count of bytes,
as RFC 7862 does not specify a unit.

Reported-by: Roland Mainz <roland.mainz@nrubsig.org>
Suggested-by: Christoph Hellwig <hch@infradead.org>
Reviewed-by: Roland Mainz <roland.mainz@nrubsig.org>
Cc: stable@vger.kernel.org # v6.7+
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4xdr.c