]> www.infradead.org Git - users/jedix/linux-maple.git/commit
spi: bcm2835: Do not call gpiod_put() on invalid descriptor
authorFlorian Fainelli <florian.fainelli@broadcom.com>
Tue, 1 Apr 2025 22:42:38 +0000 (15:42 -0700)
committerMark Brown <broonie@kernel.org>
Tue, 1 Apr 2025 23:04:40 +0000 (00:04 +0100)
commitd6691010523fe1016f482a1e1defcc6289eeea48
tree019499be67fe7ea70e5013e07d4389d976eff83e
parent3cb2a2f7eebbb0752a834708e720a914e61841a1
spi: bcm2835: Do not call gpiod_put() on invalid descriptor

If we are unable to lookup the chip-select GPIO, the error path will
call bcm2835_spi_cleanup() which unconditionally calls gpiod_put() on
the cs->gpio variable which we just determined was invalid.

Fixes: 21f252cd29f0 ("spi: bcm2835: reduce the abuse of the GPIO API")
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/20250401224238.2854256-1-florian.fainelli@broadcom.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-bcm2835.c