]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: sysctl: remove always-true condition
authorAntoine Tenart <atenart@kernel.org>
Thu, 17 Oct 2024 15:24:17 +0000 (17:24 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Wed, 23 Oct 2024 08:28:19 +0000 (10:28 +0200)
commitd631094e4d20d136f159c6e0f723b7aecbc12d2f
treec54bdd05bf06c1c9c97fbafb15935cf87a2e66d7
parent6886c14bdc309fa1c92b22f9587c5ca78f1920b7
net: sysctl: remove always-true condition

Before adding a new line at the end of the temporary buffer in
dump_cpumask, a length check is performed to ensure there is space for
it.

  len = min(sizeof(kbuf) - 1, *lenp);
  len = scnprintf(kbuf, len, ...);
  if (len < *lenp)
          kbuf[len++] = '\n';

Note that the check is currently logically wrong, the written length is
compared against the output buffer, not the temporary one. However this
has no consequence as this is always true, even if fixed: scnprintf
includes a null char at the end of the buffer but the returned length do
not include it and there is always space for overriding it with a
newline.

Remove the condition.

Signed-off-by: Antoine Tenart <atenart@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/core/sysctl_net_core.c