]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/i915/dp_mst: Fix connector initialization in intel_dp_add_mst_connector()
authorImre Deak <imre.deak@intel.com>
Mon, 18 Nov 2024 13:10:44 +0000 (15:10 +0200)
committerJani Nikula <jani.nikula@intel.com>
Mon, 18 Nov 2024 17:31:55 +0000 (19:31 +0200)
commitd58f65df2dcb59acd3965907507cfa608fe924b4
tree0edc57577d9f836bd4eda8b28d3f5fb1bf622ef9
parente725091865407fcd8d96ab9ad618c07fb6e3cc2b
drm/i915/dp_mst: Fix connector initialization in intel_dp_add_mst_connector()

The connector initialization in intel_dp_add_mst_connector() depends on
the device pointer in connector to be valid, at least by connector
debug printing. The device pointer is initialized by drm_connector_init(),
however that function also exposes the connector to in-kernel users,
which can't be done before the connector is fully initialized. For now
make sure the device pointer is valid before it's used, until a
follow-up change moving this to DRM core.

This issue was revealed by the commit in the Fixes: line below, before
which the above debug printing checked and handled a NULL device pointer
gracefully in DRM core.

Cc: Jani Nikula <jani.nikula@intel.com>
Fixes: 529798bd786a ("drm/i915/mst: convert to struct intel_display")
Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12799
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241118131044.1278028-1-imre.deak@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_dp_mst.c