]> www.infradead.org Git - users/jedix/linux-maple.git/commit
bnxt_en: Drop oversize TX packets to prevent errors.
authorMichael Chan <michael.chan@broadcom.com>
Wed, 27 Feb 2019 08:58:53 +0000 (03:58 -0500)
committerBrian Maly <brian.maly@oracle.com>
Sat, 11 May 2019 00:51:08 +0000 (20:51 -0400)
commitd4f98fb6a213bd634bca8f87ec7a052bb0b9620e
tree5c67fa3adeb83b42825e68815b057223419dd300
parent6f9087745d0e417267386e0f7744b7a223c828f5
bnxt_en: Drop oversize TX packets to prevent errors.

Orabug: 29516462

There have been reports of oversize UDP packets being sent to the
driver to be transmitted, causing error conditions.  The issue is
likely caused by the dst of the SKB switching between 'lo' with
64K MTU and the hardware device with a smaller MTU.  Patches are
being proposed by Mahesh Bandewar <maheshb@google.com> to fix the
issue.

In the meantime, add a quick length check in the driver to prevent
the error.  The driver uses the TX packet size as index to look up an
array to setup the TX BD.  The array is large enough to support all MTU
sizes supported by the driver.  The oversize TX packet causes the
driver to index beyond the array and put garbage values into the
TX BD.  Add a simple check to prevent this.

Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 2b3c6885386020b1b9d92d45e8349637e27d1f66)
Signed-off-by: Brian Maly <brian.maly@oracle.com>
drivers/net/ethernet/broadcom/bnxt/bnxt.c