]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/xe: Clarify size of MMIO region
authorMatt Roper <matthew.d.roper@intel.com>
Tue, 10 Sep 2024 23:47:23 +0000 (16:47 -0700)
committerMatt Roper <matthew.d.roper@intel.com>
Wed, 11 Sep 2024 22:17:30 +0000 (15:17 -0700)
commitd4aff99aefa2a3c8999a98f0d52a977b284b9ec9
treedd3e2d16005c3afa68942e1e21e870fb726f6167
parent34953ee349dde9d1733d4af75e929f7fd5fab539
drm/xe: Clarify size of MMIO region

xe_mmio currently has a size parameter that is assigned but never used
anywhere.  The current values assigned appear to be the size of the BAR
region assigned for the tile (both for registers and other purposes such
as the GGTT).  Since the current field isn't being used for anything,
change the assignments to 4MB (the size of the register region on all
current platform) and rename the field to 'regs_size' to more clearly
describe what it represents.  We can use this value in later patches to
help ensure no register accesses accidentally go past the end of the
desired register space (which might not be caught easily if they still
fall within the iomap).

v2:
 - s/regs_length/regs_size/  (Lucas)
 - Clarify kerneldoc description (Lucas)

Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240910234719.3335472-48-matthew.d.roper@intel.com
drivers/gpu/drm/xe/xe_device_types.h
drivers/gpu/drm/xe/xe_mmio.c