]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mm/smaps: don't access young/dirty bit if pte unpresent
authorPeter Xu <peterx@redhat.com>
Fri, 5 Aug 2022 16:00:03 +0000 (12:00 -0400)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 17 Aug 2022 20:56:07 +0000 (13:56 -0700)
commitd4932bbd3c2c1cbcb27ce7f12385cdbedc9a49b5
tree7c7017f338a9b1e60c9c39a87e0590a23205ba1d
parentbf5ec5774ade4545485a4ec38af40b415198be58
mm/smaps: don't access young/dirty bit if pte unpresent

These bits should only be valid when the ptes are present.  Introducing
two booleans for it and set it to false when !pte_present() for both pte
and pmd accountings.

The bug is found during code reading and no real world issue reported, but
logically such an error can cause incorrect readings for either smaps or
smaps_rollup output on quite a few fields.

For example, it could cause over-estimate on values like Shared_Dirty,
Private_Dirty, Referenced.  Or it could also cause under-estimate on
values like LazyFree, Shared_Clean, Private_Clean.

Link: https://lkml.kernel.org/r/20220805160003.58929-1-peterx@redhat.com
Fixes: b1d4d9e0cbd0 ("proc/smaps: carefully handle migration entries")
Fixes: c94b6923fa0a ("/proc/PID/smaps: Add PMD migration entry parsing")
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Yang Shi <shy828301@gmail.com>
Cc: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Huang Ying <ying.huang@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/proc/task_mmu.c