]> www.infradead.org Git - nvme.git/commit
net: can: j1939: enhanced error handling for tightly received RTS messages in xtp_rx_...
authorOleksij Rempel <o.rempel@pengutronix.de>
Fri, 17 Nov 2023 12:49:59 +0000 (13:49 +0100)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 21 Jun 2024 08:50:14 +0000 (10:50 +0200)
commitd3e2904f71ea0fe7eaff1d68a2b0363c888ea0fb
treec49484e397d14bdd7a2af90f65cd8057bb10a2d3
parent8851346912a1fa33e7a5966fe51f07313b274627
net: can: j1939: enhanced error handling for tightly received RTS messages in xtp_rx_rts_session_new

This patch enhances error handling in scenarios with RTS (Request to
Send) messages arriving closely. It replaces the less informative WARN_ON_ONCE
backtraces with a new error handling method. This provides clearer error
messages and allows for the early termination of problematic sessions.
Previously, sessions were only released at the end of j1939_xtp_rx_rts().

Potentially this could be reproduced with something like:
testj1939 -r vcan0:0x80 &
while true; do
# send first RTS
cansend vcan0 18EC8090#1014000303002301;
# send second RTS
cansend vcan0 18EC8090#1014000303002301;
# send abort
cansend vcan0 18EC8090#ff00000000002301;
done

Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
Reported-by: syzbot+daa36413a5cedf799ae4@syzkaller.appspotmail.com
Cc: stable@vger.kernel.org
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Link: https://lore.kernel.org/all/20231117124959.961171-1-o.rempel@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
net/can/j1939/transport.c