]> www.infradead.org Git - users/jedix/linux-maple.git/commit
arm64: dts: qcom: x1e80100-pmics: Enable all SMB2360 separately
authorStephan Gerhold <stephan.gerhold@linaro.org>
Tue, 10 Dec 2024 08:36:01 +0000 (09:36 +0100)
committerBjorn Andersson <andersson@kernel.org>
Mon, 16 Dec 2024 20:30:51 +0000 (14:30 -0600)
commitd37e2646c8a5cb8acaebd03f4ae33a1bc0d24991
treeb3504f4cfa357b923193aad60b86c6a21aadfb1d
parent45d55e2da9bd10d24c4730b452b11a76dc3960b8
arm64: dts: qcom: x1e80100-pmics: Enable all SMB2360 separately

At the moment, x1e80100-pmics.dtsi enables two of the SMB2360 PMICs by
default and leaves the other two disabled. The third one was originally
also enabled by default, but then disabled in commit a237b8da413c ("arm64:
dts: qcom: x1e80100: Disable SMB2360_2 by default"). This is inconsistent
and confusing. Some laptops will even need SMB2360_1 disabled by default if
they just have a single USB-C port.

Make this consistent by keeping all SMB2360 disabled in x1e80100-pmics.dtsi
and enable them separately for all boards where needed. That way it is
always clear which ones are available and avoids accidentally trying to
read/write from missing chips when some of the PMICs are not present.

Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
Link: https://lore.kernel.org/r/20241210-x1e80100-disable-smb2360-v2-1-2449be2eca29@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
arch/arm64/boot/dts/qcom/x1e80100-crd.dts
arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
arch/arm64/boot/dts/qcom/x1e80100-qcp.dts