]> www.infradead.org Git - users/dwmw2/linux.git/commit
ublk: fix ublk_ch_mmap() for 64K page size
authorMing Lei <ming.lei@redhat.com>
Mon, 11 Nov 2024 11:07:18 +0000 (19:07 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 11 Nov 2024 15:16:17 +0000 (08:16 -0700)
commitd369735e02ef122d19d4c3d093028da0eb400636
treec8c075414f41f2d3b3b776bbfb90346f2a65220b
parentb2113edaa9afa1c405609b3dca18a9434d28b6c5
ublk: fix ublk_ch_mmap() for 64K page size

In ublk_ch_mmap(), queue id is calculated in the following way:

(vma->vm_pgoff << PAGE_SHIFT) / `max_cmd_buf_size`

'max_cmd_buf_size' is equal to

`UBLK_MAX_QUEUE_DEPTH * sizeof(struct ublksrv_io_desc)`

and UBLK_MAX_QUEUE_DEPTH is 4096 and part of UAPI, so 'max_cmd_buf_size'
is always page aligned in 4K page size kernel. However, it isn't true in
64K page size kernel.

Fixes the issue by always rounding up 'max_cmd_buf_size' with PAGE_SIZE.

Cc: stable@vger.kernel.org
Fixes: 71f28f3136af ("ublk_drv: add io_uring based userspace block driver")
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20241111110718.1394001-1-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/ublk_drv.c