]> www.infradead.org Git - users/hch/block.git/commit
rtmutex: Drop rt_mutex::wait_lock before scheduling
authorRoland Xu <mu001999@outlook.com>
Thu, 15 Aug 2024 02:58:13 +0000 (10:58 +0800)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 15 Aug 2024 13:38:53 +0000 (15:38 +0200)
commitd33d26036a0274b472299d7dcdaa5fb34329f91b
tree97b66051307cd6ab7a476ab9af00a00a5a1850d8
parent7c626ce4bae1ac14f60076d00eafe71af30450ba
rtmutex: Drop rt_mutex::wait_lock before scheduling

rt_mutex_handle_deadlock() is called with rt_mutex::wait_lock held.  In the
good case it returns with the lock held and in the deadlock case it emits a
warning and goes into an endless scheduling loop with the lock held, which
triggers the 'scheduling in atomic' warning.

Unlock rt_mutex::wait_lock in the dead lock case before issuing the warning
and dropping into the schedule for ever loop.

[ tglx: Moved unlock before the WARN(), removed the pointless comment,
   massaged changelog, added Fixes tag ]

Fixes: 3d5c9340d194 ("rtmutex: Handle deadlock detection smarter")
Signed-off-by: Roland Xu <mu001999@outlook.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/all/ME0P300MB063599BEF0743B8FA339C2CECC802@ME0P300MB0635.AUSP300.PROD.OUTLOOK.COM
kernel/locking/rtmutex.c