]> www.infradead.org Git - users/dwmw2/linux.git/commit
nvmet-auth: assign dh_key to NULL after kfree_sensitive
authorVitaliy Shevtsov <v.shevtsov@maxima.ru>
Mon, 16 Sep 2024 17:41:37 +0000 (22:41 +0500)
committerKeith Busch <kbusch@kernel.org>
Wed, 30 Oct 2024 14:19:18 +0000 (07:19 -0700)
commitd2f551b1f72b4c508ab9298419f6feadc3b5d791
tree6ac40fc95e080317e780239e9d4937595efea059
parent42ab37eaad17aee458489c553a367621ee04e0bc
nvmet-auth: assign dh_key to NULL after kfree_sensitive

ctrl->dh_key might be used across multiple calls to nvmet_setup_dhgroup()
for the same controller. So it's better to nullify it after release on
error path in order to avoid double free later in nvmet_destroy_auth().

Found by Linux Verification Center (linuxtesting.org) with Svace.

Fixes: 7a277c37d352 ("nvmet-auth: Diffie-Hellman key exchange support")
Cc: stable@vger.kernel.org
Signed-off-by: Vitaliy Shevtsov <v.shevtsov@maxima.ru>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/target/auth.c