]> www.infradead.org Git - users/dwmw2/linux.git/commit
pinctrl: merrifield: Set default bias in case no particular value given
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 11 Nov 2020 12:06:05 +0000 (14:06 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 29 Dec 2020 12:46:46 +0000 (13:46 +0100)
commitd24e447e9127e11ec2d3e2bdbd067223d8186f3b
tree1300f2725955c4c838462601613d4c15ce0c860e
parentcbca15cf1a951f989a823c3d99d339a866e388e6
pinctrl: merrifield: Set default bias in case no particular value given

[ Upstream commit 0fa86fc2e28227f1e64f13867e73cf864c6d25ad ]

When GPIO library asks pin control to set the bias, it doesn't pass
any value of it and argument is considered boolean (and this is true
for ACPI GpioIo() / GpioInt() resources, by the way). Thus, individual
drivers must behave well, when they got the resistance value of 1 Ohm,
i.e. transforming it to sane default.

In case of Intel Merrifield pin control hardware the 20 kOhm sounds plausible
because it gives a good trade off between weakness and minimization of leakage
current (will be only 50 uA with the above choice).

Fixes: 4e80c8f50574 ("pinctrl: intel: Add Intel Merrifield pin controller support")
Depends-on: 2956b5d94a76 ("pinctrl / gpio: Introduce .set_config() callback for GPIO chips")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pinctrl/intel/pinctrl-merrifield.c