]> www.infradead.org Git - users/jedix/linux-maple.git/commit
bus: imx-weim: fix branch condition evaluates to a garbage value
authorIvan Bornyakov <i.bornyakov@metrotek.ru>
Mon, 6 Mar 2023 13:25:26 +0000 (16:25 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Mar 2023 10:49:29 +0000 (12:49 +0200)
commitd22bc65a98ff9c79402492c3133b122aa546330c
treee8ab2b2e50ccdb4b05042dcb291aeb26f8267ecd
parent286b0cab31bac29960e5684f6fb331d42f03b363
bus: imx-weim: fix branch condition evaluates to a garbage value

commit 1adab2922c58e7ff4fa9f0b43695079402cce876 upstream.

If bus type is other than imx50_weim_devtype and have no child devices,
variable 'ret' in function weim_parse_dt() will not be initialized, but
will be used as branch condition and return value. Fix this by
initializing 'ret' with 0.

This was discovered with help of clang-analyzer, but the situation is
quite possible in real life.

Fixes: 52c47b63412b ("bus: imx-weim: improve error handling upon child probe-failure")
Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
Cc: stable@vger.kernel.org
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/bus/imx-weim.c