]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ext4: fix hang when processing corrupted orphaned inode list
authorTheodore Ts'o <tytso@mit.edu>
Sat, 30 Apr 2016 04:48:54 +0000 (00:48 -0400)
committerDhaval Giani <dhaval.giani@oracle.com>
Fri, 20 Jan 2017 22:21:53 +0000 (17:21 -0500)
commitd20d677b4ba74701ef7cb6cf8a49253ae79a242c
tree6f0cae2179d42d75535f6277ecb7f7c4c825c01a
parentabd34b475abf8e2b7c9ea2e6fe7ef3de6fd7ad17
ext4: fix hang when processing corrupted orphaned inode list

Orabug: 25256921

[ Upstream commit c9eb13a9105e2e418f72e46a2b6da3f49e696902 ]

If the orphaned inode list contains inode #5, ext4_iget() returns a
bad inode (since the bootloader inode should never be referenced
directly).  Because of the bad inode, we end up processing the inode
repeatedly and this hangs the machine.

This can be reproduced via:

   mke2fs -t ext4 /tmp/foo.img 100
   debugfs -w -R "ssv last_orphan 5" /tmp/foo.img
   mount -o loop /tmp/foo.img /mnt

(But don't do this if you are using an unpatched kernel if you care
about the system staying functional.  :-)

This bug was found by the port of American Fuzzy Lop into the kernel
to find file system problems[1].  (Since it *only* happens if inode #5
shows up on the orphan list --- 3, 7, 8, etc. won't do it, it's not
surprising that AFL needed two hours before it found it.)

[1] http://events.linuxfoundation.org/sites/events/files/slides/AFL%20filesystem%20fuzzing%2C%20Vault%202016_0.pdf

Cc: stable@vger.kernel.org
Reported by: Vegard Nossum <vegard.nossum@oracle.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit 06c6dcb86328d114709b2f464ce9c6f015acad70)
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
fs/ext4/ialloc.c