]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ep_insert(): move creation of wakeup source past the fl_ep_links insertion
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 27 Sep 2020 15:03:32 +0000 (11:03 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Mon, 26 Oct 2020 00:02:05 +0000 (20:02 -0400)
commitd1ec50adb560983635bd31263012e688cc167f31
tree1dd3a968b2ffbd59b94b62d873eda7019ac16bca
parent2c0b71c1e9c9362c9503f218fed62aeb66a2ef97
ep_insert(): move creation of wakeup source past the fl_ep_links insertion

That's the beginning of preparations for taking f_ep_links out of struct file.
If insertion might fail, we will need a new failure exit.  Having wakeup
source creation done after that point will simplify life there; ep_remove()
can (and commonly does) live with NULL epi->ws, so it can be used for
cleanup after ep_create_wakeup_source() failure.  It can't be used before
the rbtree insertion, though, so if we are to unify all old failure exits,
we need to move that thing down.  Then we would be free to do simple
kmem_cache_free() on the failure to insert into f_ep_links - no wakeup source
to leak on that failure exit.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/eventpoll.c