]> www.infradead.org Git - users/dwmw2/linux.git/commit
phy: qcom-qmp-usb: Fix an NULL vs IS_ERR() bug
authorChenyuan Yang <chenyuan0y@gmail.com>
Mon, 14 Apr 2025 12:50:50 +0000 (07:50 -0500)
committerVinod Koul <vkoul@kernel.org>
Wed, 14 May 2025 08:29:44 +0000 (09:29 +0100)
commitd14402a38c2d868cacb1facaf9be908ca6558e59
tree51b65f883019625def4e3df5f6120d1f64e0ce2f
parente00c9aea31035f46b04a13effaa801f8b3419d2a
phy: qcom-qmp-usb: Fix an NULL vs IS_ERR() bug

The qmp_usb_iomap() helper function currently returns the raw result of
devm_ioremap() for non-exclusive mappings. Since devm_ioremap() may return
a NULL pointer and the caller only checks error pointers with IS_ERR(),
NULL could bypass the check and lead to an invalid dereference.

Fix the issue by checking if devm_ioremap() returns NULL. When it does,
qmp_usb_iomap() now returns an error pointer via IOMEM_ERR_PTR(-ENOMEM),
ensuring safe and consistent error handling.

Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com>
Fixes: a5d6b1ac56cb ("phy: qcom-qmp-usb: fix memleak on probe deferral")
CC: Johan Hovold <johan@kernel.org>
CC: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250414125050.2118619-1-chenyuan0y@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/qualcomm/phy-qcom-qmp-usb.c