]> www.infradead.org Git - users/jedix/linux-maple.git/commit
scsi: core: Handle devices which return an unusually large VPD page count
authorMartin K. Petersen <martin.petersen@oracle.com>
Tue, 21 May 2024 02:30:40 +0000 (22:30 -0400)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 24 May 2024 00:35:32 +0000 (20:35 -0400)
commitd09c05aa35909adb7d29f92f0cd79fdcd1338ef0
tree2d3b6c4830241858f2416b69d7de340b30623b17
parente4f5f8298cf6ddae43210d236ad65ac2c6379559
scsi: core: Handle devices which return an unusually large VPD page count

Peter Schneider reported that a system would no longer boot after
updating to 6.8.4.  Peter bisected the issue and identified commit
b5fc07a5fb56 ("scsi: core: Consult supported VPD page list prior to
fetching page") as being the culprit.

Turns out the enclosure device in Peter's system reports a byteswapped
page length for VPD page 0. It reports "02 00" as page length instead
of "00 02". This causes us to attempt to access 516 bytes (page length
+ header) of information despite only 2 pages being present.

Limit the page search scope to the size of our VPD buffer to guard
against devices returning a larger page count than requested.

Link: https://lore.kernel.org/r/20240521023040.2703884-1-martin.petersen@oracle.com
Fixes: b5fc07a5fb56 ("scsi: core: Consult supported VPD page list prior to fetching page")
Cc: stable@vger.kernel.org
Reported-by: Peter Schneider <pschneider1968@googlemail.com>
Closes: https://lore.kernel.org/all/eec6ebbf-061b-4a7b-96dc-ea748aa4d035@googlemail.com/
Tested-by: Peter Schneider <pschneider1968@googlemail.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi.c