]> www.infradead.org Git - users/willy/pagecache.git/commit
bonding: Fix initial {vlan,mpls}_feature set in bond_compute_features
authorDaniel Borkmann <daniel@iogearbox.net>
Tue, 10 Dec 2024 14:12:42 +0000 (15:12 +0100)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 12 Dec 2024 10:59:18 +0000 (11:59 +0100)
commitd064ea7fe2a24938997b5e88e6b61cbb0a4bb906
tree89b0c97452ad1b3c2529eadcef9406f65d6f47e6
parentd2516c3a53705f783bb6868df0f4a2b977898a71
bonding: Fix initial {vlan,mpls}_feature set in bond_compute_features

If a bonding device has slave devices, then the current logic to derive
the feature set for the master bond device is limited in that flags which
are fully supported by the underlying slave devices cannot be propagated
up to vlan devices which sit on top of bond devices. Instead, these get
blindly masked out via current NETIF_F_ALL_FOR_ALL logic.

vlan_features and mpls_features should reuse netdev_base_features() in
order derive the set in the same way as ndo_fix_features before iterating
through the slave devices to refine the feature set.

Fixes: a9b3ace44c7d ("bonding: fix vlan_features computing")
Fixes: 2e770b507ccd ("net: bonding: Inherit MPLS features from slave devices")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Cc: Nikolay Aleksandrov <razor@blackwall.org>
Cc: Ido Schimmel <idosch@idosch.org>
Cc: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
Link: https://patch.msgid.link/20241210141245.327886-2-daniel@iogearbox.net
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/bonding/bond_main.c