]> www.infradead.org Git - users/jedix/linux-maple.git/commit
clocksource: Make watchdog and suspend-timing multiplication overflow safe
authorAdrian Hunter <adrian.hunter@intel.com>
Mon, 25 Mar 2024 06:40:23 +0000 (08:40 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Mon, 8 Apr 2024 13:03:08 +0000 (15:03 +0200)
commitd0304569fb019d1bcfbbbce1ce6df6b96f04079b
treed900f55b9d79777af57bcb3d8daea7e1eb703af0
parent135225a363ae67bc90bde7a2cbbe1ea0f152ba22
clocksource: Make watchdog and suspend-timing multiplication overflow safe

Kernel timekeeping is designed to keep the change in cycles (since the last
timer interrupt) below max_cycles, which prevents multiplication overflow
when converting cycles to nanoseconds. However, if timer interrupts stop,
the clocksource_cyc2ns() calculation will eventually overflow.

Add protection against that. Simplify by folding together
clocksource_delta() and clocksource_cyc2ns() into cycles_to_nsec_safe().
Check against max_cycles, falling back to a slower higher precision
calculation.

Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20240325064023.2997-20-adrian.hunter@intel.com
kernel/time/clocksource.c