]> www.infradead.org Git - users/hch/misc.git/commit
ublk: check recovery flags for validity
authorUday Shankar <ushankar@purestorage.com>
Mon, 7 Oct 2024 18:24:14 +0000 (12:24 -0600)
committerJens Axboe <axboe@kernel.dk>
Tue, 22 Oct 2024 14:16:37 +0000 (08:16 -0600)
commitd00c0ea17955d2fde9ef7ebca480f4c73a594650
tree9c3e93c6ff4c5fcfcdcf87dae8733f6e2a033f59
parent110234da18ab482f6f583d28eff26b9569bf5622
ublk: check recovery flags for validity

Setting UBLK_F_USER_RECOVERY_REISSUE without also setting
UBLK_F_USER_RECOVERY is currently silently equivalent to not setting any
recovery flags at all, even though that's obviously not intended. Check
for this case and fail add_dev (with a paranoid warning to aid debugging
any program which might rely on the old behavior) with EINVAL if it is
detected.

Signed-off-by: Uday Shankar <ushankar@purestorage.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20241007182419.3263186-2-ushankar@purestorage.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/ublk_drv.c