]> www.infradead.org Git - users/jedix/linux-maple.git/commit
wifi: mwifiex: Don't use %pK through printk
authorThomas Weißschuh <thomas.weissschuh@linutronix.de>
Thu, 17 Apr 2025 13:21:54 +0000 (15:21 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Wed, 23 Apr 2025 13:36:04 +0000 (15:36 +0200)
commitcfec9f8f58a9a7b8005a8a66f51b1f7752292301
tree124f8c89e215c9fb6b30539f88986b3c0f0f75e7
parente7c0fe7a9e7f7f053ebf815cb13eb07c1055b4ca
wifi: mwifiex: Don't use %pK through printk

In the past %pK was preferable to %p as it would not leak raw pointer
values into the kernel log.
Since commit ad67b74d2469 ("printk: hash addresses printed with %p")
the regular %p has been improved to avoid this issue.
Furthermore, restricted pointers ("%pK") were never meant to be used
through printk(). They can still unintentionally leak raw pointers or
acquire sleeping looks in atomic contexts.

Switch to the regular pointer formatting which is safer and
easier to reason about.
There are still a few users of %pK left, but these use it through seq_file,
for which its usage is safe.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Acked-by: Brian Norris <briannorris@chromium.org>
Link: https://patch.msgid.link/20250417-restricted-pointers-wifi-v1-1-b79cdaae5579@linutronix.de
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/marvell/mwifiex/pcie.c