]> www.infradead.org Git - users/dwmw2/linux.git/commit
drm/vc4: Fix missing platform_unregister_drivers() call in vc4_drm_register()
authorYuan Can <yuancan@huawei.com>
Thu, 3 Nov 2022 01:47:05 +0000 (01:47 +0000)
committerMaxime Ripard <maxime@cerno.tech>
Mon, 7 Nov 2022 10:29:40 +0000 (11:29 +0100)
commitcf53db768a8790fdaae2fa3a81322b080285f7e5
treefa78fb1aa5c415dade9d856f58334e5d01f0b798
parent3bc6a37f59f21a8bfaf74d0975b2eb0b2d52a065
drm/vc4: Fix missing platform_unregister_drivers() call in vc4_drm_register()

A problem about modprobe vc4 failed is triggered with the following log
given:

 [  420.327987] Error: Driver 'vc4_hvs' is already registered, aborting...
 [  420.333904] failed to register platform driver vc4_hvs_driver [vc4]: -16
 modprobe: ERROR: could not insert 'vc4': Device or resource busy

The reason is that vc4_drm_register() returns platform_driver_register()
directly without checking its return value, if platform_driver_register()
fails, it returns without unregistering all the vc4 drivers, resulting the
vc4 can never be installed later.
A simple call graph is shown as below:

 vc4_drm_register()
   platform_register_drivers() # all vc4 drivers are registered
   platform_driver_register()
     driver_register()
       bus_add_driver()
         priv = kzalloc(...) # OOM happened
   # return without unregister drivers

Fixing this problem by checking the return value of
platform_driver_register() and do platform_unregister_drivers() if
error happened.

Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20221103014705.109322-1-yuancan@huawei.com
drivers/gpu/drm/vc4/vc4_drv.c