]> www.infradead.org Git - mtd-utils.git/commit
misc-utils: flash_erase: FIX integer overflow in flash_erase.c
authorAnton Moryakov <ant.v.moryakov@gmail.com>
Wed, 11 Dec 2024 14:04:03 +0000 (17:04 +0300)
committerDavid Oberhollenzer <david.oberhollenzer@sigma-star.at>
Tue, 17 Dec 2024 13:34:22 +0000 (14:34 +0100)
commitcf3b826cac649caac853bc319b19be133372166f
treebfb27f4b1285bc82b8850fecbfb2b6ce5c46c1ec
parent36d1ba9ba75e45da5ff049f4a4bec4ea576a9689
misc-utils: flash_erase: FIX integer overflow in flash_erase.c

Report of the static analyzer:
The value of an arithmetic expression 'eb_cnt * mtd.eb_size' is a subject to overflow because its operands are not cast to a larger data type before performing arithmetic

Corrections explained:
Added explicit casting of eb_cnt to long long in the condition
if (eb_start == 0 && mtd.size == eb_cnt * mtd.eb_size)
to ensure the multiplication is performed in a 64-bit context,
preventing potential overflow for large values of eb_cnt and mtd.eb_size.
This ensures correct handling of devices with large block counts or block sizes.

Triggers found by static analyzer Svace.

Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com>
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
misc-utils/flash_erase.c