]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/i915/gem: Improve pfn calculation readability in vm_fault_gtt()
authorAndi Shyti <andi.shyti@linux.intel.com>
Wed, 7 Aug 2024 10:45:53 +0000 (11:45 +0100)
committerAndi Shyti <andi.shyti@linux.intel.com>
Thu, 8 Aug 2024 09:49:27 +0000 (10:49 +0100)
commitcecab0bb737fb74813733f2472761fc3a93857b1
treedbe7063cd70946a9e2833dbd0969e8bb113b74c1
parent0829b5bcdd3ba077c408e71e22ac2bfa85bf2c95
drm/i915/gem: Improve pfn calculation readability in vm_fault_gtt()

By moving the pfn calculation to the set_address_limits()
function we improve code readability. This way,
set_address_limits() is responsible for calculating all memory
mapping paramenters: "start", "end" and "pfn".

This suggestion from Jonathan was made during the review of
commit 8bdd9ef7e9b1 ("drm/i915/gem: Fix Virtual Memory mapping
boundaries calculation"), which I liked, but it got lost on the
way.

Suggested-by: Jonathan Cavitt <Jonathan.cavitt@intel.com>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Reviewed-by: Krzysztof Niemiec <krzysztof.niemiec@intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240807104553.481763-1-andi.shyti@linux.intel.com
drivers/gpu/drm/i915/gem/i915_gem_mman.c