]> www.infradead.org Git - users/jedix/linux-maple.git/commit
net_sched: skbprio: Remove overly strict queue assertions
authorCong Wang <xiyou.wangcong@gmail.com>
Sat, 29 Mar 2025 22:25:35 +0000 (15:25 -0700)
committerJakub Kicinski <kuba@kernel.org>
Wed, 2 Apr 2025 23:03:32 +0000 (16:03 -0700)
commitce8fe975fd99b49c29c42e50f2441ba53112b2e8
treef47c43074638cf36c18d79320104bb6ecc087ee8
parent078aabd567de3d63d37d7673f714e309d369e6e2
net_sched: skbprio: Remove overly strict queue assertions

In the current implementation, skbprio enqueue/dequeue contains an assertion
that fails under certain conditions when SKBPRIO is used as a child qdisc under
TBF with specific parameters. The failure occurs because TBF sometimes peeks at
packets in the child qdisc without actually dequeuing them when tokens are
unavailable.

This peek operation creates a discrepancy between the parent and child qdisc
queue length counters. When TBF later receives a high-priority packet,
SKBPRIO's queue length may show a different value than what's reflected in its
internal priority queue tracking, triggering the assertion.

The fix removes this overly strict assertions in SKBPRIO, they are not
necessary at all.

Reported-by: syzbot+a3422a19b05ea96bee18@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=a3422a19b05ea96bee18
Fixes: aea5f654e6b7 ("net/sched: add skbprio scheduler")
Cc: Nishanth Devarajan <ndev2021@gmail.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Link: https://patch.msgid.link/20250329222536.696204-2-xiyou.wangcong@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sched/sch_skbprio.c