]> www.infradead.org Git - nvme.git/commit
tracing: fprobe-event: Fix to check tracepoint event and return
authorMasami Hiramatsu (Google) <mhiramat@kernel.org>
Wed, 8 Nov 2023 12:12:39 +0000 (21:12 +0900)
committerMasami Hiramatsu (Google) <mhiramat@kernel.org>
Fri, 10 Nov 2023 11:06:12 +0000 (20:06 +0900)
commitce51e6153f7781bcde0f8bb4c81d6fd85ee422e6
treedf224d09c1a1e06008d6af98823ed8535c7369b4
parentabc28463c81853e4fdf8d009f71b2a3ce62a6f40
tracing: fprobe-event: Fix to check tracepoint event and return

Fix to check the tracepoint event is not valid with $retval.
The commit 08c9306fc2e3 ("tracing/fprobe-event: Assume fprobe is
a return event by $retval") introduced automatic return probe
conversion with $retval. But since tracepoint event does not
support return probe, $retval is not acceptable.

Without this fix, ftracetest, tprobe_syntax_errors.tc fails;

[22] Tracepoint probe event parser error log check      [FAIL]
 ----
 # tail 22-tprobe_syntax_errors.tc-log.mRKroL
 + ftrace_errlog_check trace_fprobe t kfree ^$retval dynamic_events
 + printf %s t kfree
 + wc -c
 + pos=8
 + printf %s t kfree ^$retval
 + tr -d ^
 + command=t kfree $retval
 + echo Test command: t kfree $retval
 Test command: t kfree $retval
 + echo
 ----

So 't kfree $retval' should fail (tracepoint doesn't support
return probe) but passed it.

Link: https://lore.kernel.org/all/169944555933.45057.12831706585287704173.stgit@devnote2/
Fixes: 08c9306fc2e3 ("tracing/fprobe-event: Assume fprobe is a return event by $retval")
Cc: stable@vger.kernel.org
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
kernel/trace/trace_fprobe.c