]> www.infradead.org Git - users/jedix/linux-maple.git/commit
orinoco: Remove BUG_ON(in_interrupt/irq())
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Sun, 1 Nov 2020 21:15:29 +0000 (22:15 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Sat, 7 Nov 2020 15:52:16 +0000 (17:52 +0200)
commitce4dd05cbba697c748d9b665bd05467910318811
treed9c00f8ae01160d966427527489083794d6ed9e0
parent28606150768a20b291a35dbbbb0ab4dd7d4739db
orinoco: Remove BUG_ON(in_interrupt/irq())

The usage of in_irq()/in_interrupt() in drivers is phased out and the
BUG_ON()'s based on those are not covering all contexts in which these
functions cannot be called.

Aside of that BUG_ON() should only be used as last resort, which is clearly
not the case here.

A broad variety of checks in the invoked functions (always enabled or debug
option dependent) cover these conditions already, so the BUG_ON()'s do not
really provide additional value.

Just remove them.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20201101211536.2966644-2-bigeasy@linutronix.de
drivers/net/wireless/intersil/orinoco/orinoco_usb.c