]> www.infradead.org Git - users/jedix/linux-maple.git/commit
selinux: unify OOM handling in network hashtables
authorChristian Göttsche <cgzones@googlemail.com>
Tue, 18 Mar 2025 08:33:32 +0000 (09:33 +0100)
committerPaul Moore <paul@paul-moore.com>
Fri, 11 Apr 2025 20:29:51 +0000 (16:29 -0400)
commitcde3b1b66f2de9eba3ce1beadb91739d803a1018
tree240f1e23fe5076588436059e4b17b5ba23f5a9ae
parente6fb56b2253d49d192d4fe790698462d5422c041
selinux: unify OOM handling in network hashtables

For network objects, like interfaces, nodes, port and InfiniBands, the
object to SID lookup is cached in hashtables.  OOM during such hashtable
additions of new objects is considered non-fatal and the computed SID is
simply returned without adding the compute result into the hash table.

Actually ignore OOM in the InfiniBand code, despite the comment already
suggesting to do so.  This reverts commit c350f8bea271 ("selinux: Fix
error return code in sel_ib_pkey_sid_slow()").

Add comments in the other places.

Use kmalloc() instead of kzalloc(), since all members are initialized on
success and the data is only used in internbal hash tables, so no risk
of information leakage to userspace.

Fixes: c350f8bea271 ("selinux: Fix error return code in sel_ib_pkey_sid_slow()")
Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
security/selinux/ibpkey.c
security/selinux/netif.c
security/selinux/netnode.c
security/selinux/netport.c