]> www.infradead.org Git - users/jedix/linux-maple.git/commit
HID: check empty report_list in hid_validate_values()
authorPietro Borrello <borrello@diag.uniroma1.it>
Mon, 16 Jan 2023 11:11:24 +0000 (11:11 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 Feb 2023 07:34:19 +0000 (08:34 +0100)
commitcdcdc0531a51659527fea4b4d064af343452062d
tree8cf7aa33adecae73d9a7d194a923b6c3431b1314
parent7879626296e6ffd838ae0f2af1ab49ee46354973
HID: check empty report_list in hid_validate_values()

[ Upstream commit b12fece4c64857e5fab4290bf01b2e0317a88456 ]

Add a check for empty report_list in hid_validate_values().
The missing check causes a type confusion when issuing a list_entry()
on an empty report_list.
The problem is caused by the assumption that the device must
have valid report_list. While this will be true for all normal HID
devices, a suitably malicious device can violate the assumption.

Fixes: 1b15d2e5b807 ("HID: core: fix validation of report id 0")
Signed-off-by: Pietro Borrello <borrello@diag.uniroma1.it>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hid/hid-core.c