]> www.infradead.org Git - users/jedix/linux-maple.git/commit
sched/fair: Fix external p->on_rq users
authorPeter Zijlstra <peterz@infradead.org>
Thu, 10 Oct 2024 09:38:10 +0000 (11:38 +0200)
committerIngo Molnar <mingo@kernel.org>
Mon, 14 Oct 2024 07:14:35 +0000 (09:14 +0200)
commitcd9626e9ebc77edec33023fe95dab4b04ffc819d
treef634627362f80150130afc99ccda5cf58e584614
parentc6508124193d42bbc3224571eb75bfa4c1821fbb
sched/fair: Fix external p->on_rq users

Sean noted that ever since commit 152e11f6df29 ("sched/fair: Implement
delayed dequeue") KVM's preemption notifiers have started
mis-classifying preemption vs blocking.

Notably p->on_rq is no longer sufficient to determine if a task is
runnable or blocked -- the aforementioned commit introduces tasks that
remain on the runqueue even through they will not run again, and
should be considered blocked for many cases.

Add the task_is_runnable() helper to classify things and audit all
external users of the p->on_rq state. Also add a few comments.

Fixes: 152e11f6df29 ("sched/fair: Implement delayed dequeue")
Reported-by: Sean Christopherson <seanjc@google.com>
Tested-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lkml.kernel.org/r/20241010091843.GK33184@noisy.programming.kicks-ass.net
include/linux/sched.h
kernel/events/core.c
kernel/freezer.c
kernel/rcu/tasks.h
kernel/sched/core.c
kernel/time/tick-sched.c
kernel/trace/trace_selftest.c
virt/kvm/kvm_main.c