]> www.infradead.org Git - users/dwmw2/linux.git/commit
virtio-blk: Don't use MAX_DISCARD_SEGMENTS if max_discard_seg is zero
authorXie Yongji <xieyongji@bytedance.com>
Fri, 4 Mar 2022 10:00:57 +0000 (18:00 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Mar 2022 13:15:57 +0000 (14:15 +0100)
commitcca9d5035bd055a8824ae9e8e1e144eb22ae4b0b
tree33e4574ec5bc85a02118a53b7d5f6d395493ed7c
parenta3d5fcc6cf2ecbba5a269631092570aa285a24cb
virtio-blk: Don't use MAX_DISCARD_SEGMENTS if max_discard_seg is zero

[ Upstream commit dacc73ed0b88f1a787ec20385f42ca9dd9eddcd0 ]

Currently the value of max_discard_segment will be set to
MAX_DISCARD_SEGMENTS (256) with no basis in hardware if device
set 0 to max_discard_seg in configuration space. It's incorrect
since the device might not be able to handle such large descriptors.
To fix it, let's follow max_segments restrictions in this case.

Fixes: 1f23816b8eb8 ("virtio_blk: add discard and write zeroes support")
Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
Link: https://lore.kernel.org/r/20220304100058.116-1-xieyongji@bytedance.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/block/virtio_blk.c