]> www.infradead.org Git - users/jedix/linux-maple.git/commit
gpiolib: use a more explicit retval logic in gpiochip_get_direction()
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 26 Feb 2025 10:12:30 +0000 (11:12 +0100)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Thu, 27 Feb 2025 07:57:50 +0000 (08:57 +0100)
commitcc78604fd4799a8e8e9d23ea4898acd6b605982d
tree414b5c70259db7e7a7ffc59314d0736932a00244
parent9becde08f1bc2857cd66f847eca2aaec3fc05c21
gpiolib: use a more explicit retval logic in gpiochip_get_direction()

We have existing macros for direction settings so we don't need to rely
on the magic value of 1 in the retval check. Use readable logic that
explicitly says we expect INPUT, OUTPUT or a negative errno and nothing
else in gpiochip_get_direction().

Fixes: e623c4303ed1 ("gpiolib: sanitize the return value of gpio_chip::get_direction()")
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Closes: https://lore.kernel.org/all/Z7yfTggRrk3K6srs@black.fi.intel.com/
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20250226-retval-fixes-v2-2-c8dc57182441@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpiolib.c