]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/panel: himax-hx8394: Handle errors from mipi_dsi_dcs_set_display_on() better
authorDouglas Anderson <dianders@chromium.org>
Fri, 17 May 2024 21:36:36 +0000 (14:36 -0700)
committerNeil Armstrong <neil.armstrong@linaro.org>
Tue, 21 May 2024 08:01:19 +0000 (10:01 +0200)
commitcc2db2ef8d9eebc0df03808ac0dadbdb96733499
tree3990e390dca9ef2d8c71b47950fc979ba29be293
parentb593ea9406237739d2da42e6f245c390d8a69f43
drm/panel: himax-hx8394: Handle errors from mipi_dsi_dcs_set_display_on() better

If mipi_dsi_dcs_set_display_on() returned an error then we'd store
that in the "ret" variable and jump to error handling. We'd then
attempt an orderly poweroff. Unfortunately we then blew away the value
stored in "ret". That means that if the orderly poweroff actually
worked then we're return 0 (no error) from hx8394_enable() even though
the panel wasn't enabled.

Fix this by not blowing away "ret".

Found by code inspection.

Fixes: 65dc9360f741 ("drm: panel: Add Himax HX8394 panel controller driver")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20240517143643.1.I0a6836fffd8d7620f353becb3df2370d2898f803@changeid
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240517143643.1.I0a6836fffd8d7620f353becb3df2370d2898f803@changeid
drivers/gpu/drm/panel/panel-himax-hx8394.c