]> www.infradead.org Git - users/dwmw2/linux.git/commit
fgraph: Still initialize idle shadow stacks when starting
authorSteven Rostedt <rostedt@goodmis.org>
Wed, 11 Dec 2024 18:53:35 +0000 (13:53 -0500)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Mon, 16 Dec 2024 21:03:33 +0000 (16:03 -0500)
commitcc252bb592638e0f7aea40d580186c36d89526b8
tree3f784da246300ceb9bbce2c9e5e29cedfc075d96
parent78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8
fgraph: Still initialize idle shadow stacks when starting

A bug was discovered where the idle shadow stacks were not initialized
for offline CPUs when starting function graph tracer, and when they came
online they were not traced due to the missing shadow stack. To fix
this, the idle task shadow stack initialization was moved to using the
CPU hotplug callbacks. But it removed the initialization when the
function graph was enabled. The problem here is that the hotplug
callbacks are called when the CPUs come online, but the idle shadow
stack initialization only happens if function graph is currently
active. This caused the online CPUs to not get their shadow stack
initialized.

The idle shadow stack initialization still needs to be done when the
function graph is registered, as they will not be allocated if function
graph is not registered.

Cc: stable@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://lore.kernel.org/20241211135335.094ba282@batman.local.home
Fixes: 2c02f7375e65 ("fgraph: Use CPU hotplug mechanism to initialize idle shadow stacks")
Reported-by: Linus Walleij <linus.walleij@linaro.org>
Tested-by: Linus Walleij <linus.walleij@linaro.org>
Closes: https://lore.kernel.org/all/CACRpkdaTBrHwRbbrphVy-=SeDz6MSsXhTKypOtLrTQ+DgGAOcQ@mail.gmail.com/
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/fgraph.c