]> www.infradead.org Git - users/hch/xfs.git/commit
hwmon: (max6697) Fix underflow when writing limit attributes
authorGuenter Roeck <linux@roeck-us.net>
Sat, 13 Jul 2024 21:26:19 +0000 (14:26 -0700)
committerGuenter Roeck <linux@roeck-us.net>
Sun, 14 Jul 2024 18:48:50 +0000 (11:48 -0700)
commitcbf7467828cd4ec7ceac7a8b5b5ddb2f69f07b0e
treeea3f27fe8bc3ff750d7310cbab1af9d7fdc1f058
parented99ae74f2328e42286880c946953a8f9dd95a7e
hwmon: (max6697) Fix underflow when writing limit attributes

Using DIV_ROUND_CLOSEST() on an unbound value can result in underflows.
Indeed, module test scripts report:

temp1_max: Suspected underflow: [min=0, read 255000, written -9223372036854775808]
temp1_crit: Suspected underflow: [min=0, read 255000, written -9223372036854775808]

Fix by introducing an extra set of clamping.

Fixes: 5372d2d71c46 ("hwmon: Driver for Maxim MAX6697 and compatibles")
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/max6697.c