]> www.infradead.org Git - users/jedix/linux-maple.git/commit
xfs: fix a double completion for buffers on in-memory targets
authorChristoph Hellwig <hch@lst.de>
Mon, 13 Jan 2025 14:12:05 +0000 (15:12 +0100)
committerCarlos Maiolino <cem@kernel.org>
Tue, 14 Jan 2025 10:38:14 +0000 (11:38 +0100)
commitcbd6883ed8662073031a32f1294cdf53c8ec24a4
tree524209935279021dbef02efc9bf581e7e5781f97
parent9d9b72472631262b35157f1a650f066c0e11c2bb
xfs: fix a double completion for buffers on in-memory targets

__xfs_buf_submit calls xfs_buf_ioend when b_io_remaining hits zero.  For
in-memory buftargs b_io_remaining is never incremented from it's initial
value of 1, so this always happens.  Thus the extra call to xfs_buf_ioend
in _xfs_buf_ioapply causes a double completion.  Fortunately
__xfs_buf_submit is only used for synchronous reads on in-memory buftargs
due to the peculiarities of how they work, so this is mostly harmless and
just causes a little extra work to be done.

Fixes: 5076a6040ca1 ("xfs: support in-memory buffer cache targets")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Acked-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
fs/xfs/xfs_buf.c