]> www.infradead.org Git - users/jedix/linux-maple.git/commit
media: davinci: vpif_display: Mix memory leak on probe error path
authorAnton Vasilyev <vasilyev@ispras.ru>
Fri, 27 Jul 2018 11:52:20 +0000 (07:52 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Sep 2018 20:43:39 +0000 (22:43 +0200)
commitcbd5e67820a998cfb7f3d7a1b995d0bc2a1f00f7
tree86b916fec59c92bd437096d2b8d16018805609fa
parent77e120a9c64afb52b3ca199d23ef45b4c840dccc
media: davinci: vpif_display: Mix memory leak on probe error path

[ Upstream commit 61e641f36ed81ae473177c085f0bfd83ad3b55ed ]

If vpif_probe() fails on v4l2_device_register() then memory allocated
at initialize_vpif() for global vpif_obj.dev[i] become unreleased.

The patch adds deallocation of vpif_obj.dev[i] on the error path and
removes duplicated check on platform_data presence.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/platform/davinci/vpif_display.c