]> www.infradead.org Git - users/dwmw2/linux.git/commit
net/mlx5e: Correctly report errors for ethtool rx flows
authorCosmin Ratiu <cratiu@nvidia.com>
Thu, 8 Aug 2024 14:41:05 +0000 (17:41 +0300)
committerJakub Kicinski <kuba@kernel.org>
Sat, 10 Aug 2024 05:16:46 +0000 (22:16 -0700)
commitcbc796be1779c4dbc9a482c7233995e2a8b6bfb3
treef557c49fe7c1bfb3fa4fed83b0018486e2b93909
parente6b5afd30b99b43682a7764e1a74a42fe4d5f4b3
net/mlx5e: Correctly report errors for ethtool rx flows

Previously, an ethtool rx flow with no attrs would not be added to the
NIC as it has no rules to configure the hw with, but it would be
reported as successful to the caller (return code 0). This is confusing
for the user as ethtool then reports "Added rule $num", but no rule was
actually added.

This change corrects that by instead reporting these wrong rules as
-EINVAL.

Fixes: b29c61dac3a2 ("net/mlx5e: Ethtool steering flow validation refactoring")
Signed-off-by: Cosmin Ratiu <cratiu@nvidia.com>
Reviewed-by: Saeed Mahameed <saeedm@nvidia.com>
Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20240808144107.2095424-5-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/en_fs_ethtool.c