]> www.infradead.org Git - users/jedix/linux-maple.git/commit
perf report: Fix condition in sort__sym_cmp()
authorNamhyung Kim <namhyung@kernel.org>
Fri, 21 Jun 2024 17:05:25 +0000 (10:05 -0700)
committerNamhyung Kim <namhyung@kernel.org>
Tue, 25 Jun 2024 18:06:20 +0000 (11:06 -0700)
commitcb39d05e67dc24985ff9f5150e71040fa4d60ab8
treebd3cce892ceeaab24ae51caa8c852ada285b94cb
parentdd9a426eade634bf794c7e0f1b0c6659f556942f
perf report: Fix condition in sort__sym_cmp()

It's expected that both hist entries are in the same hists when
comparing two.  But the current code in the function checks one without
dso sort key and other with the key.  This would make the condition true
in any case.

I guess the intention of the original commit was to add '!' for the
right side too.  But as it should be the same, let's just remove it.

Fixes: 69849fc5d2119 ("perf hists: Move sort__has_dso into struct perf_hpp_list")
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240621170528.608772-2-namhyung@kernel.org
tools/perf/util/sort.c