]> www.infradead.org Git - users/jedix/linux-maple.git/commit
wifi: iwlwifi: work around -Wenum-compare-conditional warning
authorArnd Bergmann <arnd@arndb.de>
Fri, 18 Oct 2024 15:18:34 +0000 (15:18 +0000)
committerJohannes Berg <johannes.berg@intel.com>
Wed, 23 Oct 2024 15:33:47 +0000 (17:33 +0200)
commitcadae7ead4434d6c4ca15fb74cc729fb868fcca3
tree88754b3261f7c7c708c55a1d4e58781d82d0621d
parent188a1bf894323bf3a90361676da8364c82ce6d32
wifi: iwlwifi: work around -Wenum-compare-conditional warning

This is one of only three -Wenum-compare-conditional warnings we get
in randconfig builds:

drivers/net/wireless/intel/iwlwifi/mvm/sta.c:4331:17: error: conditional expression between different enumeration types ('enum iwl_fw_sta_type' and 'enum iwl_sta_type') [-Werror,-Wenum-compare-conditional]
 4331 |         u32 type = mld ? STATION_TYPE_PEER : IWL_STA_LINK;
      |                        ^ ~~~~~~~~~~~~~~~~~   ~~~~~~~~~~~~

This is a false positive since the code works as intended, but the
warning is otherwise sensible, so slightly rewrite it in order to
not trigger the warning.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://patch.msgid.link/20241018151841.3821671-1-arnd@kernel.org
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/sta.c