]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/i915/selftests: Change mock_request() to return error pointers
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 25 Jun 2025 15:21:58 +0000 (10:21 -0500)
committerJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
Mon, 30 Jun 2025 05:12:33 +0000 (08:12 +0300)
commitcaa7c7a76b78ce41d347003f84975125383e6b59
tree75ff489cd7f537640f0d570fffd3edd80e2a07d9
parentd0b3b7b22dfa1f4b515fd3a295b3fd958f9e81af
drm/i915/selftests: Change mock_request() to return error pointers

There was an error pointer vs NULL bug in __igt_breadcrumbs_smoketest().
The __mock_request_alloc() function implements the
smoketest->request_alloc() function pointer.  It was supposed to return
error pointers, but it propogates the NULL return from mock_request()
so in the event of a failure, it would lead to a NULL pointer
dereference.

To fix this, change the mock_request() function to return error pointers
and update all the callers to expect that.

Fixes: 52c0fdb25c7c ("drm/i915: Replace global breadcrumbs with per-context interrupt tracking")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://lore.kernel.org/r/685c1417.050a0220.696f5.5c05@mx.google.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
(cherry picked from commit 778fa8ad5f0f23397d045c7ebca048ce8def1c43)
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
drivers/gpu/drm/i915/selftests/i915_request.c
drivers/gpu/drm/i915/selftests/mock_request.c