]> www.infradead.org Git - users/jedix/linux-maple.git/commit
media: synopsys: hdmirx: Fix signedness bug in hdmirx_parse_dt()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 7 Mar 2025 09:30:16 +0000 (12:30 +0300)
committerHans Verkuil <hverkuil@xs4all.nl>
Fri, 7 Mar 2025 10:02:16 +0000 (11:02 +0100)
commitca8dc5951b6be04bb6e2b69a1606c8fbaa5e4fb4
treec476e713c824a809ce64e19d75ca39b7272c052b
parentfae8cab4ba3a76bb883eca176bc442eb5e6d581e
media: synopsys: hdmirx: Fix signedness bug in hdmirx_parse_dt()

The num_clks is set this way:

hdmirx_dev->num_clks = devm_clk_bulk_get_all(dev, &hdmirx_dev->clks);
        if (hdmirx_dev->num_clks < 1)
                return -ENODEV;

The devm_clk_bulk_get_all() function returns negative error codes so the
hdmirx_dev->num_cks variable needs to be signed for the error handling to
work.

Fixes: 7b59b132ad43 ("media: platform: synopsys: Add support for HDMI input driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c