]> www.infradead.org Git - users/jedix/linux-maple.git/commit
clk: qcom: gcc-x1e80100: Don't use parking clk_ops for QUPs
authorBryan O'Donoghue <bryan.odonoghue@linaro.org>
Fri, 23 Aug 2024 12:58:56 +0000 (13:58 +0100)
committerStephen Boyd <sboyd@kernel.org>
Tue, 27 Aug 2024 18:02:18 +0000 (11:02 -0700)
commitca082333b4356688be715ed9cc762fc5d3d5f4c5
tree41ebae9b18aa09cea4fc942bf1e9a1031a3e8f81
parent0f6eaf125e73fecb6a864fd22b131f23423bd0a7
clk: qcom: gcc-x1e80100: Don't use parking clk_ops for QUPs

Per Stephen Boyd's explanation in the link below, QUP RCG clocks do not
need to be parked when switching frequency. A side-effect in parking to a
lower frequency can be a momentary invalid clock driven on an in-use serial
peripheral.

This can cause "junk" to spewed out of a UART as a low-impact example. On
the x1e80100-crd this serial port junk can be observed on linux-next.

Apply a similar fix to the x1e80100 Global Clock controller to remediate.

Link: https://lore.kernel.org/all/20240819233628.2074654-3-swboyd@chromium.org/
Fixes: 161b7c401f4b ("clk: qcom: Add Global Clock controller (GCC) driver for X1E80100")
Fixes: 929c75d57566 ("clk: qcom: gcc-sm8550: Mark RCGs shared where applicable")
Suggested-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Link: https://lore.kernel.org/r/20240823-x1e80100-clk-fix-v1-1-0b1b4f5a96e8@linaro.org
Reviewed-by: Konrad Dybcio <konradybcio@kernel.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/qcom/gcc-x1e80100.c