]> www.infradead.org Git - users/dwmw2/linux.git/commit
serial: 8250: Use @ier bits to determine if Rx is stopped
authorJohn Ogness <john.ogness@linutronix.de>
Mon, 16 Dec 2024 17:12:41 +0000 (18:18 +0106)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 23 Dec 2024 17:59:59 +0000 (18:59 +0100)
commitc9f49e3e45fccae1841ae61bc5187fef18419ce6
tree28e1a1ce8562d39426a1130d7d25fa2d1650ca8e
parente95cb63e57381f00d9274533ea7fd0ac3bf4e5b0
serial: 8250: Use @ier bits to determine if Rx is stopped

Commit f19c3f6c8109 ("serial: 8250_port: Don't service RX FIFO if
throttled") uses @read_status_mask (bit UART_LSR_DR) to determine
if Rx has been stopped. However, the bit UART_LSR_DR is not
managed properly in @read_status_mask for all Rx stop/start
situations and is therefore not suitable for this purpose.

Use the UART_IER_RLSI and UART_IER_RDI bits in @ier instead, as
this is already common in 8250-variants and drivers.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
Link: https://lore.kernel.org/r/20241216171244.12783-2-john.ogness@linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_port.c