]> www.infradead.org Git - users/jedix/linux-maple.git/commit
btrfs: do not output error message if a qgroup has been already cleaned up
authorQu Wenruo <wqu@suse.com>
Sun, 19 Jan 2025 23:10:43 +0000 (09:40 +1030)
committerDavid Sterba <dsterba@suse.com>
Thu, 23 Jan 2025 21:34:11 +0000 (22:34 +0100)
commitc9c863793395cf0a66c2778a29d72c48c02fbb66
tree2838281351fbae889088cd4ff193892c726f7658
parent0d85f5c2dd91df6b5da454406756f463ba923b69
btrfs: do not output error message if a qgroup has been already cleaned up

[BUG]
There is a bug report that btrfs outputs the following error message:

  BTRFS info (device nvme0n1p2): qgroup scan completed (inconsistency flag cleared)
  BTRFS warning (device nvme0n1p2): failed to cleanup qgroup 0/1179: -2

[CAUSE]
The error itself is pretty harmless, and the end user should ignore it.

When a subvolume is fully dropped, btrfs will call
btrfs_qgroup_cleanup_dropped_subvolume() to delete the qgroup.

However if a qgroup rescan happened before a subvolume fully dropped,
qgroup for that subvolume will not be re-created, as rescan will only
create new qgroup if there is a BTRFS_ROOT_REF_KEY found.

But before we drop a subvolume, the subvolume is unlinked thus there is no
BTRFS_ROOT_REF_KEY.

In that case, btrfs_remove_qgroup() will fail with -ENOENT and trigger
the above error message.

[FIX]
Just ignore -ENOENT error from btrfs_remove_qgroup() inside
btrfs_qgroup_cleanup_dropped_subvolume().

Reported-by: John Shand <jshand2013@gmail.com>
Link: https://bugzilla.suse.com/show_bug.cgi?id=1236056
Fixes: 839d6ea4f86d ("btrfs: automatically remove the subvolume qgroup")
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/qgroup.c