]> www.infradead.org Git - users/jedix/linux-maple.git/commit
regulator: gpio: Fix the out-of-bounds access to drvdata::gpiods
authorManivannan Sadhasivam <mani@kernel.org>
Thu, 3 Jul 2025 10:35:49 +0000 (16:05 +0530)
committerMark Brown <broonie@kernel.org>
Thu, 3 Jul 2025 11:22:35 +0000 (12:22 +0100)
commitc9764fd88bc744592b0604ccb6b6fc1a5f76b4e3
tree7658e88cadc707a6b965c201491039d884f33d99
parent6729c134ccc0d37d865c342e466b90df29081f1a
regulator: gpio: Fix the out-of-bounds access to drvdata::gpiods

drvdata::gpiods is supposed to hold an array of 'gpio_desc' pointers. But
the memory is allocated for only one pointer. This will lead to
out-of-bounds access later in the code if 'config::ngpios' is > 1. So
fix the code to allocate enough memory to hold 'config::ngpios' of GPIO
descriptors.

While at it, also move the check for memory allocation failure to be below
the allocation to make it more readable.

Cc: stable@vger.kernel.org # 5.0
Fixes: d6cd33ad7102 ("regulator: gpio: Convert to use descriptors")
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Link: https://patch.msgid.link/20250703103549.16558-1-mani@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/gpio-regulator.c