]> www.infradead.org Git - users/willy/linux.git/commit
bna: adjust 'name' buf size of bna_tcb and bna_ccb structures
authorAlexey Kodanev <aleksei.kodanev@bell-sw.com>
Mon, 8 Jul 2024 10:50:08 +0000 (10:50 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 12 Jul 2024 00:56:48 +0000 (01:56 +0100)
commitc9741a03dc8e491e57b95fba0058ab46b7e506da
tree5aa364b20ac75e1aa1f0d773645e8d96b59200e1
parent80ab5445da623540ea6303740015dd0210a06dc8
bna: adjust 'name' buf size of bna_tcb and bna_ccb structures

To have enough space to write all possible sprintf() args. Currently
'name' size is 16, but the first '%s' specifier may already need at
least 16 characters, since 'bnad->netdev->name' is used there.

For '%d' specifiers, assume that they require:
 * 1 char for 'tx_id + tx_info->tcb[i]->id' sum, BNAD_MAX_TXQ_PER_TX is 8
 * 2 chars for 'rx_id + rx_info->rx_ctrl[i].ccb->id', BNAD_MAX_RXP_PER_RX
   is 16

And replace sprintf with snprintf.

Detected using the static analysis tool - Svace.

Fixes: 8b230ed8ec96 ("bna: Brocade 10Gb Ethernet device driver")
Signed-off-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/brocade/bna/bna_types.h
drivers/net/ethernet/brocade/bna/bnad.c