]> www.infradead.org Git - users/hch/dma-mapping.git/commit
usb: dwc3: Wait for EndXfer completion before restoring GUSB2PHYCFG
authorPrashanth K <quic_prashk@quicinc.com>
Tue, 24 Sep 2024 09:32:08 +0000 (15:02 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Oct 2024 08:25:28 +0000 (10:25 +0200)
commitc96e31252110a84dcc44412e8a7b456b33c3e298
treecf4a34738f821aaea0b974fcee8be4c18cde6c41
parentffe85c24d7ca5de7d57690c0ab194b3838674935
usb: dwc3: Wait for EndXfer completion before restoring GUSB2PHYCFG

DWC3 programming guide mentions that when operating in USB2.0 speeds,
if GUSB2PHYCFG[6] or GUSB2PHYCFG[8] is set, it must be cleared prior
to issuing commands and may be set again  after the command completes.
But currently while issuing EndXfer command without CmdIOC set, we
wait for 1ms after GUSB2PHYCFG is restored. This results in cases
where EndXfer command doesn't get completed and causes SMMU faults
since requests are unmapped afterwards. Hence restore GUSB2PHYCFG
after waiting for EndXfer command completion.

Cc: stable@vger.kernel.org
Fixes: 1d26ba0944d3 ("usb: dwc3: Wait unconditionally after issuing EndXfer command")
Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/20240924093208.2524531-1-quic_prashk@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/gadget.c